Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security issues and security-related navigation issues #2707

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

myxmaster
Copy link
Contributor

Description

This fixes #1946, #2655 and #2659.

  • replaced attemptAdminLogin with pendingNavigation to allow for navigation from POS to Menu
  • allow using biometry when leaving POS
  • use popTo() instead of navigate() in Lockscreen to remove Lockscreen from stack and prevent duplicate screens on stack
  • added return after proceeding to wallet if POS is active

FYI: Not a regression but an existing bug: If Keypad is configured as default view, leaving POS navigates to Balance, not Keypad. I'm going to create an issue for this.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

…o Menu, prevent navigating back to lockscreen, allow biometry from POS
@myxmaster myxmaster changed the title Fix security and security-related navigation issues Fix security issues and security-related navigation issues Jan 5, 2025
@kaloudis kaloudis requested a review from shubhamkmr04 January 6, 2025 16:00
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the POS is active, we dont see the lockscreen when we come to the app from background

@shubhamkmr04
Copy link
Contributor

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-01-09.at.16.37.12.1.mp4

@myxmaster
Copy link
Contributor Author

That is wanted :)

@shubhamkmr04
Copy link
Contributor

That is wanted :)

Oh ok. rest of the updates looks good.

@kaloudis kaloudis merged commit b679efa into ZeusLN:master Jan 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POS: allow biometrics to be used as lock for rest of the app
3 participants